This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Simplify/fix when to check for designated invalid function #5661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going over this code with @cds-amal and realized it could be simplified. I noticed that when the index is not
-1, but we don't have an AST, we didn't check for the designated invalid function. I was like, wait, why don't we? I should add that check. And then I realized these could be combined -- if the index is-1, thenastwill necessarily be undefined, so checking if the index is-1really doesn't need to be separate. So, now it's simplified a bit.I only did manual testing of this since it requires old Solidity versions to hit this code. I tested it on 0.5.0, it worked fine.